[PATCH] D145771: [LICM] Support logical AND/OR when hoisting min/max

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 10 01:34:04 PST 2023


nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

As mentioned on the other review, if the RHS is non-poison, then InstCombine will already convert logical to bitwise op. There's no need to reimplement a weaker check here. If we want to handle logical and/or in this context, the way to do it is to freeze the RHS, which will allow to always perform the fold.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145771/new/

https://reviews.llvm.org/D145771



More information about the llvm-commits mailing list