[PATCH] D143535: github: Add manual workflow to build and upload release binaries

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: .github/workflows/release-binaries.yml:53
+
+        if [ -n "${{ inputs.upload }}" ]; then
+          upload="${{ inputs.upload }}"
----------------
kwk wrote:
> I wonder if this will work. When I today tried this I got `false` and `true` values. That's why I check differently. The string comparison is safe this way.
The intended logic is for upload to be true if inputs.upload is unset.  Otherwise upload should equal inputs.upload. 


================
Comment at: .github/workflows/set-release-binary-outputs.sh:25
+echo "rc-flags=$rc_flags" >> $GITHUB_OUTPUT
+echo "upload=$upload" >> $GITHUB_OUTPUT
+echo "ref=$tag" >> $GITHUB_OUTPUT
----------------
kwk wrote:
> This one is not listed in the `outputs:` section of of the `prepare` job.
It's there now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143535/new/

https://reviews.llvm.org/D143535