[PATCH] D145710: [ORC] Fix name shadowing issue, NFC.

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

Hi Aman,

This change looks fine, however naming the constructor argument for the member variable is idiomatic in ORC (and common elsewhere in LLVM from memory), and something like this should usually be resolved by explicitly specifying `this->`. Ideally constructor bodies should be small enough to spot bugs like this easily, but that's not the case here -- we should probably try to break this constructor body out into a separate method (which has the advantage of simplifying error returns too).

- Lang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145710/new/

https://reviews.llvm.org/D145710