[PATCH] D143637: StackProtector: add unwind cleanup paths for instrumentation.

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/DwarfEHPrepare.cpp:176
+  LandingPadInst *LP = BB.getLandingPadInst();
+  if (LP->isCleanup())
+    return;
----------------
xiangzhangllvm wrote:
> LGTM, just a question.
> Do we will really generate a Landing Pad for try catch pairs without cleanup in real world ?
> Should it report error earlier if without cleanup?
> Anyway this patch enhance for them.
> 
Sorry, here only for personality function not visible try catch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143637/new/

https://reviews.llvm.org/D143637