[PATCH] D145677: [ConstraintElimination] Fix undefined behaviour in shl decomposition

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 18:12:28 PST 2023


vitalybuka added a comment.

In D145677#4182592 <https://reviews.llvm.org/D145677#4182592>, @NathanielMcVicar wrote:

> This change appears to have broken the Windows MLIR bot (I suspect others Windows builders).
> https://lab.llvm.org/buildbot/#/builders/13/builds/32862/steps/6/logs/stdio
>
>   C:\buildbot\mlir-x64-windows-ninja\llvm-project\llvm\lib\Transforms\Scalar\ConstraintElimination.cpp(382): error C2220: the following warning is treated as an error
>   C:\buildbot\mlir-x64-windows-ninja\llvm-project\llvm\lib\Transforms\Scalar\ConstraintElimination.cpp(382): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)

UBSAN as well https://lab.llvm.org/buildbot/#/builders/238/builds/1810


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145677/new/

https://reviews.llvm.org/D145677



More information about the llvm-commits mailing list