[PATCH] D138883: [PowerPC] find and reuse ConstantSplatVector to combine constant store into extract and store

Thu Mar 9 17:27:47 PST 2023

tingwang added a comment.

In D138883#4181453 <https://reviews.llvm.org/D138883#4181453>, @nemanjai wrote:

> Sorry, I had unsubmitted comments. Not sure if they still apply.

Hi Nemanja,

Appreciate your help! I planned to change due to the reason that `DAGCombiner::getStoreMergeCandidates()` already walks through chain of stores, and I realized that it could be a better place to find candidate for this opportunity. By the way, maybe the criteria of `splat of constant` could be relieved to just match the subsection that is extracted by the target store, and I would like to have a try.

I hope next version will be final for review. Thank you again for taking time looking into this!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138883/new/

https://reviews.llvm.org/D138883