[PATCH] D145757: [SelectionDAG] Fix mismatched truncate when combine BUILD_VECTOR with EXTRACT_SUBVECTOR

[JunMa via Phabricator via llvm-commits]

junparser created this revision.
junparser added reviewers: tlively, craig.topper, RKSimon.
Herald added subscribers: pmatos, asb, ecnelises, hiraditya, jgravelle-google, sbc100, dschuff.
Herald added a project: All.
junparser requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

Just use correct type for truncation. Fixes PR59625


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145757

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/WebAssembly/pr59625.ll


Index: llvm/test/CodeGen/WebAssembly/pr59625.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/WebAssembly/pr59625.ll
@@ -0,0 +1,18 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
+; RUN: llc < %s -mtriple=wasm32-- -mattr=+simd128 | FileCheck --check-prefix=CHECK %s
+; RUN: llc < %s -mtriple=wasm64-- -mattr=+simd128 | FileCheck --check-prefix=CHECK %s
+
+define <1 x i16> @f(<1 x i16> %0) {
+; CHECK-LABEL: f:
+; CHECK:         .functype f (v128) -> (v128)
+; CHECK-NEXT:  # %bb.0: # %BB
+; CHECK-NEXT:    v128.const 0, 0, 0, 0, 0, 0, 0, 0
+; CHECK-NEXT:    # fallthrough-return
+BB:
+  %B2 = srem <1 x i16> %0, %0
+  br label %BB1
+
+BB1:                                             ; preds = %BB
+  %B = urem <1 x i16> %B2, <i16 3>
+  ret <1 x i16> %B
+}
Index: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -23517,7 +23517,7 @@
         if (NumElems == 1) {
           SDValue Src = V->getOperand(IdxVal);
           if (EltVT != Src.getValueType())
-            Src = DAG.getNode(ISD::TRUNCATE, SDLoc(N), InVT, Src);
+            Src = DAG.getNode(ISD::TRUNCATE, SDLoc(N), EltVT, Src);
           return DAG.getBitcast(NVT, Src);
         }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145757.503988.patch
Type: text/x-patch
Size: 1433 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230310/ac56cc6a/attachment.bin>