[PATCH] D106129: [ExecutionEngine] Check for libunwind before calling __register_frame

[Harald van Dijk via Phabricator via llvm-commits]

hvdijk added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp:72
+ * of __unw_add_dynamic_fde to detect libunwind. */
+#ifdef HAVE_UNW_ADD_DYNAMIC_FDE
 
----------------
tstellar wrote:
> Should this be a runtime check and not a compile time check?
It only makes a difference if we build against libgcc and then change it at runtime to use libunwind, or vice versa. In general, I think that if `__register_frame` behaves differently between the two versions, we cannot support that anyway. We could make it work specifically in the case of LLVM as a special exception, but if we want to make that work in general, it would be more useful to modify libunwind to be compatible with libgcc rather than making changes here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106129/new/

https://reviews.llvm.org/D106129