[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 14:32:47 PST 2023


snehasish added a comment.

In D145190#4181789 <https://reviews.llvm.org/D145190#4181789>, @snehasish wrote:

> In D145190#4181608 <https://reviews.llvm.org/D145190#4181608>, @tejohnson wrote:
>
>> lgtm - but does this depend on D145644 <https://reviews.llvm.org/D145644> and require some additional test changes?
>
> Yes, I will rebase this patch once that is submitted. I need to look at the LLVM.Transforms/PGOProfile::memprof.ll test failures.

@tejohnson I've rebased the patch and updated the raw profiles for all the tests with the new version. Also added a new test for llvm-profdata to check the buildid we serialize in the raw profile. No changes to the code from prior diffs. PTAL, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145190/new/

https://reviews.llvm.org/D145190



More information about the llvm-commits mailing list