[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

[Joshua Cranmer via Phabricator via llvm-commits]

jcranmer-intel added a comment.

I'm studiously ignoring the Clang and LLVM codegen changes here, but otherwise, I think the direction of this change is generally good.



================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1377-1378
     llvm_unreachable("unknown denormal mode");
-    return Operand;
+  case DenormalMode::Dynamic:
+    return nullptr;
   case DenormalMode::IEEE:
----------------
You should change the doxygen documentation to indicate that this method returns nullptr if the denormal mode is dynamic.

Ditto for ConstantFoldFPInstOperands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142907/new/

https://reviews.llvm.org/D142907