[PATCH] D145619: extend llvm variables for build flexibility

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 10:22:45 PST 2023


smeenai added a comment.

Heh, "target" being an extremely overloaded term strikes again :)

You're using target in the sense of an LLVM backend target (`LLVM_TARGETS_TO_BUILD`). I meant it in the sense of a build system target, e.g. `clang`, `lld`, `llvm-ar`, `libLLVMAnalysis.a`, etc. Every tool, utility and library that you're trying to enable or disable at the CMake level has its own build system target, and you should only specify the build system targets you need, instead of trying to limit that at the configuration level and then building every single target. There's also umbrella targets like `llvm-libraries` and `clang-libraries` as conveniences for referring to all libraries for a particular project.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145619/new/

https://reviews.llvm.org/D145619



More information about the llvm-commits mailing list