[PATCH] D145626: [WebAssembly] Support debug info for TLS + global in PIC mode

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

In D145626#4179867 <https://reviews.llvm.org/D145626#4179867>, @aheejin wrote:

> Only debug info won't work. So the devtools DWARF extension (https://chrome.google.com/webstore/detail/cc%20%20-devtools-support-dwa/pdcpmagijalfljmkmjngeonclgbbannb) will display `undefined` or some garbage value for TLS variables in dynamic linking. But that's the status quo for them anyway.

Just so I'm clear, this is TLS + dynamic linking + split-dwarf, right?

Since the test does actually run that case, maybe it makes sense to put a comment in there about what the output should look like once that case is fixed?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:496
+    // For now we hardcode the indices in the callsites. Global indices are not
+    // fixed, but in practice a few are fixed; for example, __stack_overflow is
+    // always index 0.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145626/new/

https://reviews.llvm.org/D145626