[PATCH] D145688: [StructurizeCFG] Use UniformityAnalysis instead of DivergenceAnalysis

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 06:09:13 PST 2023


Pierre-vh added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/StructurizeCFG.cpp:802
-  if (DA)
-    DA->removeValue(Term);
   Term->eraseFromParent();
----------------
foad wrote:
> Does UA need something like removeValue? I see it was added by @nhaehnle in D43743 "to avoid dangling pointers as a matter of defensive programming".
I'm not too familiar with UA's implementation so I can't answer this, @sameerds does UA need anything like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145688/new/

https://reviews.llvm.org/D145688



More information about the llvm-commits mailing list