[PATCH] D145619: extend llvm variables for build flexibility

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

I agree with @smeenai, I think we should try to come with a more maintainable and less error prone approach.

LLVM libraries and tools have dependencies. If the user enables only a subset of libraries or tools, but not their dependencies, it'll result in broken output. Since the build graph evolves over time, the set of libraries and tools that needs to be selected is also going to change over time complicating the maintenance.

This is not just a theoretical concern; in Fuchsia we build a subset of LLVM libraries <https://fuchsia.googlesource.com/infra/recipes/+/refs/heads/main/recipes/contrib/llvm.py#260> for use in our debugger (we use `LLVM_DISTRIBUTION_COMPONENTS` to specify which ones) and our build breaks regularly because of changing dependencies to the point where we started looking for a better solution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145619/new/

https://reviews.llvm.org/D145619