[PATCH] D144189: [AIX][CodeGen] Storage Locations for Constant Pointers

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 22:25:25 PST 2023


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2408
+  if (TM.Options.ReadOnlyPointers && Kind.isReadOnlyWithRel()) {
+    assert(TM.getDataSections() &&
+           "ReadOnlyPointers is supported only if data sections is turned on");
----------------
The option seems out of the control of the back-end to me (it is "user input"). I believe `report_fatal_error` may be more appropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144189/new/

https://reviews.llvm.org/D144189



More information about the llvm-commits mailing list