[PATCH] D8966: Extend s{,n}printf custom wrappers to support '*' in the format specifiers

[Wu Yingcong via Phabricator via llvm-commits]

yingcong-wu added inline comments.
Herald added subscribers: Enna1, delcypher.
Herald added a project: All.


================
Comment at: compiler-rt/trunk/lib/dfsan/dfsan_custom.cc:1046
+          va_labels++;
+          dfsan_set_label(0, ptr, sizeof(ptr));
+          end_fmt = true;
----------------
Hi guys, should it be `dfsan_set_label(0, ptr, sizeof(*ptr)` so that we set label for what ptr points to. I think it can be problems when `sizeof(ptr) != sizeof(*ptr)`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D8966/new/

https://reviews.llvm.org/D8966