[PATCH] D145619: extend llvm variables for build flexibility

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai requested changes to this revision.
smeenai added reviewers: beanz, compnerd, phosek, tstellar.
smeenai added a comment.
This revision now requires changes to proceed.

Adding the usual CMake reviewers.

We've generally tried to move away from the direction of having CMake variables to include/exclude parts of the build, and instead encourage users to only build the specific targets they need instead of the `all` target. LLVM's CMake has support for distributions <https://llvm.org/docs/BuildingADistribution.html> to make that more ergonomic. LLVM also exports its targets, so Rust could import them and add a dependency on them directly. Do either of those work for you?

You should upload patches with full context. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface if you're using the web interface or https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line if you set up Arcanist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145619/new/

https://reviews.llvm.org/D145619