[PATCH] D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-dwarfdump/ARM/aligned_line_tables.s:54
+// Next line table
+.long 58        // Unit total length
+.short 2        // Version
----------------
`.long 58` is at offset 40, which is a multiple of 8 (also a multiple of 4).
I suggest that you create at least 3 RUN lines to cover the multiple-of-4, multiple-of-8, not-multiple-of-4 cases.

```
.ifdef XXX
.asciz "test.c"
.else
.asciz "testxxxx.c"  // appropriate number of padding bytes
.endif
```

If you do this, my earlier comment about using a label difference will show its advantage...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143513/new/

https://reviews.llvm.org/D143513