[PATCH] D144759: [AMDGPU] Implement idempotent atomic lowering
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 8 14:08:32 PST 2023
rampitec added a comment.
In D144759#4179328 <https://reviews.llvm.org/D144759#4179328>, @arsenm wrote:
> Still don't understand why this isn't just a generic / default implementation
In the form as I did it it probably can be a generic optimization. The fence part is questionable because in reality it would need not a fence, but a corresponding cache flush. Then I see that x86 want to avoid it specifically for atomic 'or' operation because they have a better lowering, so making it generic will cause x86 to regress.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144759/new/
https://reviews.llvm.org/D144759
More information about the llvm-commits
mailing list