[PATCH] D145586: [AMDGPU] Tweak PromoteAlloca limits

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

Increasing the limit may result in more spilling in other cases. In general a good performance testing is needed to reason if this is beneficial.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:181
-    MaxVGPRs = ST.getMaxNumVGPRs(ST.getWavesPerEU(F).first);
-    // A non-entry function has only 32 caller preserved registers.
-    // Do not promote alloca which will force spilling.
----------------
Isn't this still true? You might not see alloca, but you will see spills.


================
Comment at: llvm/test/CodeGen/AMDGPU/vector-alloca-limits.ll:6
 
-; OPT-LABEL: @alloca_8xi64_max1024(
-; OPT-NOT: alloca
----------------
I would not drop or change tests, but rather add new as needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145586/new/

https://reviews.llvm.org/D145586