[PATCH] D145404: [LLVM] Remove support for constant scalable vector GEPs.

Wed Mar 8 07:56:45 PST 2023

paulwalker-arm added inline comments.

================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2353-2355
-      // If datalayout has no special restrictions on vector data layout,
-      // replace `llvm.vscale` by an equivalent constant expression
-      // to benefit from cheap constant propagation.
----------------
nikic wrote:
> paulwalker-arm wrote:
> > Just being able to remove this wholesale seems optimistic but it doesn't seem to have any relevant test coverage.
> I'd suggest landing this as a separate change ahead of time.
Just a note to say I've followed this advice and landed the CodeGenPrepare change via https://reviews.llvm.org/rGadbdf273efd5 and will await any fallout before landing the rest of this patch, probably towards the end of next week.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145404/new/

https://reviews.llvm.org/D145404