[PATCH] D145586: [AMDGPU] Tweak PromoteAlloca limits

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 07:43:51 PST 2023


Pierre-vh added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/vector-alloca-limits.ll:86
-; LIMIT32-NOT: <9 x i128>
-define amdgpu_kernel void @alloca_9xi128_max256(ptr addrspace(1) %out, i32 %index) #2 {
-entry:
----------------
Pierre-vh wrote:
> arsenm wrote:
> > I wouldn't expect deleting these cases
> I added some i128 test cases back in. Interestingly, 9xi128 is converted but not 17xi64 for some reason, do you know why?
Oh right, we don't convert >16 elt arrays. That's why the i128 test case was useful, my bad - should have looked more into it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145586/new/

https://reviews.llvm.org/D145586



More information about the llvm-commits mailing list