[PATCH] D145540: [InstCombine] Reduce absolute diff from min+max+sub

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 06:52:45 PST 2023


RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp:2413
+      match(Op1, m_OneUse(m_Intrinsic<Intrinsic::smin>(m_Specific(X),
+                                                       m_Specific(Y))))) {
+    if (I.hasNoUnsignedWrap() || I.hasNoSignedWrap()) {
----------------
What about cases where we have smin(Y,X) instead?


================
Comment at: llvm/test/Transforms/InstCombine/sub-minmax.ll:1051
   ret <2 x i8> %ab
 }
 
----------------
multi use negative tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145540/new/

https://reviews.llvm.org/D145540



More information about the llvm-commits mailing list