[PATCH] D145578: [AArch64] Cost-model vector splat LD1Rs to avoid unprofitable SLP vectorisation

Wed Mar 8 05:35:03 PST 2023

ABataev added inline comments.

================
Comment at: llvm/test/Transforms/SLPVectorizer/AArch64/slp-fma-loss.ll:86
 define void @slp_profitable_missing_fmf_on_fadd_fsub(ptr %A, ptr %B) {
 ; CHECK-LABEL: @slp_profitable_missing_fmf_on_fadd_fsub(
 ; CHECK-NEXT:    [[GEP_B_1:%.*]] = getelementptr inbounds float, ptr [[B:%.*]], i64 1
----------------
SjoerdMeijer wrote:
> SjoerdMeijer wrote:
> > Ah, only after uploading this diff I noticed that the function names indicate that this should be profitable... I had missed that.
> > 
> > Hmmm.... I guess that then needs looking into.
> Eyeballing this, my first reaction is that I slightly doubt that SLP will be profitable, but I guess that's what I need to find out.
Working on fma vectorization support in SLP, hope to spend more time on this later this month.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145578/new/

https://reviews.llvm.org/D145578