[PATCH] D145538: [NFC][AArch64] Document and improve FMV code.

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

Generally seems reasonable to me, but I'll give others a chance to comment.



================
Comment at: clang/lib/AST/ASTContext.cpp:13459
     if (Target->validateCpuSupports(Feature.str()))
+      // Use '?' to mark features that came from TargetVersion
       ResFeats.push_back("?" + Feature.str());
----------------



================
Comment at: clang/lib/AST/ASTContext.cpp:13529
           VFeature = VFeature.trim();
+          // Use '?' to mark features that came from AArch64 TargetClones
           Features.push_back((StringRef{"?"} + VFeature).str());
----------------



================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:610-612
+  for (const auto &E : llvm::AArch64::Extensions)
+    if (Name == E.Name)
+      return !E.DependentFeatures.empty();
----------------
Good place for `llvm::find_if` rather than a manual loop?


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:617
+StringRef AArch64TargetInfo::getFeatureDependencies(StringRef Name) const {
+  for (const auto &E : llvm::AArch64::Extensions)
+    if (Name == E.Name)
----------------
Good place for `llvm::find_if` rather than a manual loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145538/new/

https://reviews.llvm.org/D145538