[PATCH] D145565: [DebugInfo][InstrRef] Instrument x86 CMOV conversion to preserve variable values

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

Nice! LGTM with nit / question inline.



================
Comment at: llvm/test/DebugInfo/MIR/InstrRef/x86-cmov-converter.mir:8
+# involves more decomposition of instructions.
+#
+# CHECK-LABEL: bb.2.entry:
----------------
Do these `CHECK` lines cover both functions / part of the test? IMO it's not entirely clear. Maybe it's worth adding another `CHECK-LABEL`  to improve clarity?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145565/new/

https://reviews.llvm.org/D145565