[PATCH] D145413: [docs] Update README and GettingStarted

Wed Mar 8 04:43:45 PST 2023

aaron.ballman added a comment.

LGTM as-is, but I did have some comments you can feel free to take or leave.

================
Comment at: llvm/docs/GettingStarted.rst:48

      Some common build system generators are:

----------------
Should we link to CMake's generator documentation here?

================
Comment at: llvm/docs/GettingStarted.rst:75-76

-     * ``-DLLVM_ENABLE_ASSERTIONS=On`` --- Compile with assertion checks enabled
-       (default is Yes for Debug builds, No for all other build types).
+     * ``-DLLVM_ENABLE_ASSERTIONS=ON`` --- Compile with assertion checks enabled
+       (default is ON for Debug builds, OFF for all other build types).

----------------
Should we advertise `LLVM_PARALLEL_{COMPILE,LINK}_JOBS` and `LLVM_USE_LINKER` given how important those are to getting a working build on some platforms? (This can be done later if you don't want to do it as part of this patch.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145413/new/

https://reviews.llvm.org/D145413