[PATCH] D145490: [GlobalOpt] Collect initializer when building GlobalPart.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 8 03:42:13 PST 2023


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:388-394
+      auto It =
+          Parts
+              .try_emplace(
+                  Offset.getZExtValue(),
+                  GlobalPart{Ty, ConstantFoldLoadFromConst(GV->getInitializer(),
+                                                           Ty, Offset, DL)})
+              .first;
----------------
nikic wrote:
> or so to only compute this once?
Yeah that's better, updated!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145490/new/

https://reviews.llvm.org/D145490



More information about the llvm-commits mailing list