[PATCH] D144489: [VPlan] Replace InvariantCond field from VPWidenSelectRecipe.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Nice cleanup! Indicate patch is [NFC]?



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:965
+  bool isInvariantCond() const {
+    return getOperand(0)->isDefinedOutsideVectorRegions();
+  }
----------------
nit: worth adding getCond() to VPWidenSelectRecipe? (Independent of this patch.)

nit: better place isInvariantCond() method below, after con/destructor?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:968
 
 public:
   template <typename IterT>
----------------
nit: `public:` here is now redundant given that `class` became `struct`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144489/new/

https://reviews.llvm.org/D144489