[PATCH] D143149: [X86][MemFold] Update some records for X86MemFoldTables.inc

[Kan Shengchen via Phabricator via llvm-commits]

skan accepted this revision.
skan added a comment.
This revision is now accepted and ready to land.

In D143149#4177139 <https://reviews.llvm.org/D143149#4177139>, @yubing wrote:

> In D143149#4151875 <https://reviews.llvm.org/D143149#4151875>, @skan wrote:
>
>> Generally LGTM, but could we remove the blank line at the end of the file?
>
> do we need to remove the blank line between each table, actually the blank line is generated by:
>
>   void printTable(const FoldTable &Table, StringRef TableName,
>                   formatted_raw_ostream &OS) {
>     OS << "static const X86MemoryFoldTableEntry MemoryFold" << TableName
>        << "[] = {\n";
>   
>     for (auto &E : Table)
>       E.second.print(OS);
>   
>     OS << "};\n\n";
>   }
>
> if we change  OS << "};\n\n"; to  OS << "};\n";
> the blank line between each table will be lost as well.

I see. I thought it is an accidental blank


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143149/new/

https://reviews.llvm.org/D143149