[PATCH] D144783: [ELF] Move getSectionAndRelocations to ELF.cpp from ELFDumper.cpp

Wed Mar 8 00:58:34 PST 2023

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/call-graph-profile.test:355
+## Check that we report a warning when we fail to get sections due to a
+## failure in getSectionAndRelocations()
+
----------------
I'm not conviced we should mention the function name here - it could easily rot. It could just say "failed to get a section associated with a relocation section" or something to that effect.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/call-graph-profile.test:357
+
+--- !ELF
+FileHeader:
----------------
The YAML is usually after the actual test case that it is used in.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/call-graph-profile.test:367
+    Info: 0xFF
+Symbols:
+  - Name: foo
----------------
Do you actually need the symbols?

================
Comment at: llvm/test/tools/llvm-readobj/ELF/call-graph-profile.test:376
+# LLVM-RELOC-NO-SECTIONS: warning: '[[FILE]]': unable to get CG Profile section(s): SHT_RELA section with index 1: failed to get a relocated section: invalid section index: 255
\ No newline at end of file

----------------
Nit: no new line at EOF.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144783/new/

https://reviews.llvm.org/D144783