[PATCH] D137096: [llvm-readobj] Provide Hash Histogram for all ELFDumper implementations

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Two minor points, otherwise LGTM.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2770
+  // coverage of the symbols.
+  printHashHistogramStats(NBucket, MaxChain, TotalSyms, Count, /*IsGnu*/ false);
+}
----------------



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4972
+                                                 ArrayRef<size_t> Count,
+                                                 bool IsGnu) const {
   size_t CumulativeNonZero = 0;
----------------
I have a marginal preference to make this argument `StringRef TableDescription` (with values of "" and `.gnu.hash' respectively, since there's only one place the behaviour is different between the two output styles, as far as I can tell.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137096/new/

https://reviews.llvm.org/D137096