[PATCH] D145406: [RISCV][NFC] Break ReadVRGatherVV into ReadVRGatherVV_data and ReadVRGatherVV_index to separate the reads for VRGatherVV

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 21:02:10 PST 2023


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:948
   def X  : VALUVX<funct6, OPIVX, opcodestr # "." # vw # "x">,
-           Sched<[WriteVRGatherVX_UpperBound, ReadVRGatherVV_UpperBound,
+           Sched<[WriteVRGatherVX_UpperBound, ReadVRGatherVV_data_UpperBound,
                   ReadVRGatherVX_UpperBound, ReadVMask]>;
----------------
These instructions are so different that we should fully split the Reads between the 3 instructions.

We need ReadVRGatherVX_data_UpperBound and ReadVRGatherVI_data_UpperBound.

And ReadVRGatherVX_UpperBound needs to renamed to ReadVRGatherVX_index_UpperBound.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145406/new/

https://reviews.llvm.org/D145406



More information about the llvm-commits mailing list