[PATCH] D145542: [RISCV] Don't parse the decimal minimum value for fli.s/fli.d/fli.h.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 20:54:05 PST 2023


craig.topper created this revision.
craig.topper added reviewers: reames, joshua-arch1, asb, zixuan-wu.
Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added subscribers: pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

There are a couple bugs in the current support for this:
-We do all the parsing in single precision so any value less than or
 equal to the minimum fp32 is accepted as the minimum value for f64.
-To support fp16 minimum value, getLoadFP32Imm has a special case, but
 that causes a miscompile in CodeGen.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145542

Files:
  llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
  llvm/test/CodeGen/RISCV/float-zfa.ll
  llvm/test/MC/RISCV/zfa-invalid.s
  llvm/test/MC/RISCV/zfa-valid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145542.503221.patch
Type: text/x-patch
Size: 7003 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230308/7775c039/attachment.bin>


More information about the llvm-commits mailing list