[PATCH] D144759: [AMDGPU] Implement idempotent atomic lowering

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 15:26:40 PST 2023


rampitec updated this revision to Diff 503169.
rampitec marked 2 inline comments as done.
rampitec added a comment.

OK, let's be on a safe side. https://www.hpl.hp.com/techreports/2012/HPL-2012-68.pdf tells than a release fence is needed for load ordering if rmw is release or stronger. Legalizer does not do it just by itself, although the only noticeable difference in codegen is with seq_cst, which looks reasonable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144759/new/

https://reviews.llvm.org/D144759

Files:
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.h
  llvm/test/CodeGen/AMDGPU/idemponent-atomics.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144759.503169.patch
Type: text/x-patch
Size: 7719 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230307/8dcef2c5/attachment.bin>


More information about the llvm-commits mailing list