[PATCH] D143841: [Propeller] Make decoding BBAddrMaps trace through relocations

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/lib/Object/ELF.cpp:707
+        return createError("failed to get relocation data for offset: " +
+                           Twine(SectionOffset) + " in section " +
+                           describe(*this, Sec));
----------------
jhenderson wrote:
> I wonder if `utohexstr` would be better here, to give a hex offset?
Thank you for the suggestion. I would think it would definitely be better here to be consistent with the rest of the output from the LLVM tools.


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:712
+    if (IsRelocatable)
+      RelaSec = *RelocSec;
+    Expected<std::vector<BBAddrMap>> BBAddrMapOrErr =
----------------
rahmanl wrote:
> This can be `nullptr`. 
Added some error handling here and a test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143841/new/

https://reviews.llvm.org/D143841