[PATCH] D145455: [lld-macho] Coalesce local symbol aliases along with their aliased weak def

Leonard Grey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 11:22:25 PST 2023


lgrey accepted this revision.
lgrey added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Patched this in, and this fixes both the bug I mentioned on the other change as well as another one that was setting aliasee sizes to zero in STABS.



================
Comment at: lld/MachO/SymbolTable.cpp:79
+    if (d != skip) {
+      // This repeated insertion will be quadratic unless insertId is the end
+      // iterator. However, that is typically the case for files that have
----------------
insertIt


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145455/new/

https://reviews.llvm.org/D145455



More information about the llvm-commits mailing list