[PATCH] D145212: Only split cold blocks with more than a given number of instructions

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added a comment.

In D145212#4174199 <https://reviews.llvm.org/D145212#4174199>, @kristof.beyls wrote:

> It seems to me that this patch would also need:
>
> - Some regression test to test it actually changes code generation (only?) when targeting Arm.
> - As is, this patch will not result in changed code generation IIUC?

Yes, a small test for this would be great. The existing tests live in `llvm-project/llvm/test/CodeGen/X86/machine-function-splitter.ll`. I don't think this enhancement has much utility on X86, so perhaps the tests should be under `CodeGen/AArch64` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145212/new/

https://reviews.llvm.org/D145212