[PATCH] D145463: [Inliner][NFC] Remove redundant nullptr check

Alex MacLean via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 10:38:49 PST 2023


AlexM added a comment.

In D145463#4175715 <https://reviews.llvm.org/D145463#4175715>, @mtrofin wrote:

> Would adding an `assert(Callee && "Expected to be non-null due to check at the start of the loop")` (or something like that) above the `if`-check make Coverity happy?

Either removing the check completely or moving it from the `if` to an `assert` will make Coverity happy. Would the assert be preferable to complete removal from a stylistic/readability perspective?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145463/new/

https://reviews.llvm.org/D145463



More information about the llvm-commits mailing list