[PATCH] D145497: [AArch64] Allocate emergency spillslot when using fixed-length SVE.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2979
+
+  TypeSize Scale = TypeSize::Fixed(1);
+  unsigned Width;
----------------
Is this initialisation required?


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2985-2986
+
+  for (auto MBBI = MF.begin(), MBBE = MF.end(); MBBI != MBBE; ++MBBI) {
+    for (auto I = MBBI->begin(), E = MBBI->end(); I != E; ++I) {
+      unsigned Opc = I->getOpcode();
----------------
This seems a bit "belt and braces". You sure there's no other solution?


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2992
+      if (any_of(I->operands(),
+                 [](const MachineOperand &Op) { return Op.isFI(); }))
+        return true;
----------------
Is the StackID of this frame index also relevant? As in, you only care about accesses to the non-scalable stack region?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145497/new/

https://reviews.llvm.org/D145497