[PATCH] D145171: [FSAFDO] Improve FS discriminator encoding

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:1924
+  /// return scope name (the demangled name).
+  const StringRef getName() const {
+    DISubprogram *SP = getScope()->getSubprogram();
----------------
nit: name it `getSubprogramLinkageName`? 


================
Comment at: llvm/lib/CodeGen/AsmPrinter/PseudoProbePrinter.cpp:35
   while (InlinedAt) {
-    const DISubprogram *SP = InlinedAt->getScope()->getSubprogram();
-    // Use linkage name for C++ if possible.
-    auto Name = SP->getLinkageName();
-    if (Name.empty())
-      Name = SP->getName();
+    auto Name = InlinedAt->getName();
     // Use caching to avoid redundant md5 computation for build speed.
----------------
Thanks for fixing this!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145171/new/

https://reviews.llvm.org/D145171