[PATCH] D144711: [DAGCombiner] don't reuse the pointer info for merged store

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18984
+  // use the first store's frame index for other frames.
+  for (unsigned i = 0; i < NumStores; ++i)
+    if (StoreNodes[i].MemNode->getMemOperand()->getPseudoValue())
----------------
foad wrote:
> Remove `NumStores` and use range-based for loops like `for (const auto &StoreNode : StoreNodes)`. Maybe also combine the two loops into one?
Make senses Thanks for the good lessons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144711/new/

https://reviews.llvm.org/D144711