[PATCH] D145371: [AArch64TargetParser] reinstate assert for optional

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 02:43:21 PST 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rG0fcd4177063a: [AArch64TargetParser] reinstate assert for optional (authored by tmatheson).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145371/new/

https://reviews.llvm.org/D145371

Files:
  llvm/include/llvm/TargetParser/AArch64TargetParser.h


Index: llvm/include/llvm/TargetParser/AArch64TargetParser.h
===================================================================
--- llvm/include/llvm/TargetParser/AArch64TargetParser.h
+++ llvm/include/llvm/TargetParser/AArch64TargetParser.h
@@ -288,6 +288,8 @@
       return this->Version > Other.Version;
     }
     if (this->Version.getMajor() == 9 && Other.Version.getMajor() == 8) {
+      assert(this->Version.getMinor() && Other.Version.getMinor() &&
+             "AArch64::ArchInfo should have a minor version.");
       return this->Version.getMinor().value_or(0) + 5 >=
              Other.Version.getMinor().value_or(0);
     }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145371.502969.patch
Type: text/x-patch
Size: 641 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230307/b13324ac/attachment.bin>


More information about the llvm-commits mailing list