[PATCH] D144711: [DAGCombiner] don't reuse the pointer info for merged store

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 02:41:13 PST 2023


foad added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18984
+  // use the first store's frame index for other frames.
+  for (unsigned i = 0; i < NumStores; ++i)
+    if (StoreNodes[i].MemNode->getMemOperand()->getPseudoValue())
----------------
Remove `NumStores` and use range-based for loops like `for (const auto &StoreNode : StoreNodes)`. Maybe also combine the two loops into one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144711/new/

https://reviews.llvm.org/D144711



More information about the llvm-commits mailing list