[PATCH] D145008: [ControlHeightReduction] Don't combine a "poison" branch

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM. I looked into this a bit more, and CHR is not just reordering the checks, but also hoisting them across other conditions. It should be possible to limit when `freeze` is applied, but the conditions for doing this aren't obvious to me, so I'm fine with landing this in the meantime.



================
Comment at: llvm/test/Transforms/PGOProfile/chr-poison.ll:100
+!27 = !{i32 999990, i64 1, i32 750171}
+!28 = !{i32 999999, i64 1, i32 750171}
+!29 = !{!"function_entry_count", i64 3204}
----------------
Please reduce unnecessary metadata.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145008/new/

https://reviews.llvm.org/D145008