[PATCH] D144101: [test-suite] Increase the --filter-short threshold

Tue Mar 7 01:58:25 PST 2023

fhahn added a comment.

In D144101#4174512 <https://reviews.llvm.org/D144101#4174512>, @rengolin wrote:

> In D144101#4174508 <https://reviews.llvm.org/D144101#4174508>, @fhahn wrote:
>
>> It would probably be even better to make the threshold an argument (perhaps pass the threshold optionally like `--filter-short=N`), with the default being 1.0?
>
> I like this idea. Where would the argument come from in the buildbots? CMake?

I think the script is mostly (only?) used for local analysis of the results.json files generated by LNT/running the benchmarks using llvm-lit, so I would expect this to be provided by the person running the script in most cases. I might be missing some potential use cases though.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144101/new/

https://reviews.llvm.org/D144101