[PATCH] D143841: [Propeller] Make decoding BBAddrMaps trace through relocations

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Code looks broadly fine, but I don't see any testing for the error cases?



================
Comment at: llvm/lib/Object/ELF.cpp:707
+        return createError("failed to get relocation data for offset: " +
+                           Twine(SectionOffset) + " in section " +
+                           describe(*this, Sec));
----------------
I wonder if `utohexstr` would be better here, to give a hex offset?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143841/new/

https://reviews.llvm.org/D143841