[PATCH] D145009: Split getCompileUnitFor{Data,Code}Address.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Yep, looks good. (interestingly, this implementation might be missing some functionality for Split DWARF - in a Split DWARF build I didn't see any perf improvement, because I think there was no perf degredation - because this feature isn't properly implemented for Split DWARF, I'd guess)

But for a non-Split DWARF build this patch does improve performance:

From: 1m16.880s
To: 0m17.188s

Thanks for doing this - also looks like we have internal use that ended up with some workarounds that can be cleaned up by this API change too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145009/new/

https://reviews.llvm.org/D145009