[PATCH] D145249: [TargetParser] Disallow Global Constructors

Mon Mar 6 20:59:22 PST 2023

dblaikie added a comment.

In D145249#4167428 <https://reviews.llvm.org/D145249#4167428>, @tmatheson wrote:

> @mehdi_amini can you explain what the original reasoning behind this restriction was for Support, and whether we need to make the same restriction for TargetParser now that it's split out?

Global ctors/dtors are discouraged/disallowed by the LLVM style guide in general: https://llvm.org/docs/CodingStandards.html#do-not-use-static-constructors

So basically, I think, any library that can have the warning/error enabled should - to ensure we conform to this style rule, and don't regress.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145249/new/

https://reviews.llvm.org/D145249