[PATCH] D145308: [lld][WebAssembly] Initial support for stub objects

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/SymbolTable.cpp:45
+    f->parse();
+    stubFiles.push_back(f);
+    return;
----------------
pmatos wrote:
> What happens with stub files that have duplicates? Say
> 
> foo: x, y
> foo: z
> 
> Should the dependencies be x, y, z or should this be disallowed?
Good point.  I modified the implementation so that the dependencies are dictated only by the first stub object that contains that symbol. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145308/new/

https://reviews.llvm.org/D145308